[Hub Generated] Review request for Microsoft.Resources to add version stable/2019-11-01#7839
Conversation
…6-01 to version 2019-11-01
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
| "type": "string", | ||
| "description": "The physical location of the Azure location." | ||
| }, | ||
| "pairedRegion": { |
There was a problem hiding this comment.
Well, this data shouldn't be modified.
| ], | ||
| "x-ms-enum": { | ||
| "name": "SubscriptionState", | ||
| "modelAsString": false |
There was a problem hiding this comment.
why modelAsString false? it will cause breaking change in SDK for future updating
There was a problem hiding this comment.
That is how it was from the api-version I copied, I think it hasn't been updated since (2019-06-01)
yungezz
added
the
WaitForARMFeedback
KrisBash
added
ARMSignedOff
|
hi @ezgambac is this PR ready to merge? could you pls fix prettiercheck by following instruction at https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#prettier-check? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release⌛ Pending...
|
azure-sdk-for-java - Release⌛ Pending...
|
azure-sdk-for-js - Release⌛ Pending...
|
azure-sdk-for-net - Release⌛ Pending...
|
|
@yungezz Fixed the prettier error, this is good to go. |
azure-sdk-for-python - Release⌛ Pending...
|
… stable/2019-11-01 (Azure#7839)
| ```yaml $(tag) == 'package-2019-11' | ||
| input-file: | ||
| - Microsoft.Resources/stable/2019-11-01/subscriptions.json |
There was a problem hiding this comment.
Isn't this against the convention? Shouldn't it be package-subscriptions-2019-11?
| ``` yaml $(package-deploymentscripts) | ||
| tag: package-deploymentscripts-2019-10-preview | ||
| tag: package-2019-11 |
There was a problem hiding this comment.
Shouldn't these two lines match? In this case, it is package-deploymentscripts -> package-2019-11 -> Microsoft.Resources/stable/2019-11-01/subscriptions.json which isn't a correct mapping.
Randomly removed in Azure#7839 Adjusted paths for Azure/autorest repo reorg
Randomly removed in #7839 Adjusted paths for Azure/autorest repo reorg
5 participants
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: